Skip to content

Conversation

halvortf
Copy link
Member

Looked at some bugs from feedback.

Please review and give thoughts if there are any.

Changes done:

  • How score number is showed (now e.g. "2.5/5 stars")
  • Loads 20 games for each page
  • GameCards doesn't look wacky when there are only 20 - N games loaded
  • Truncation enabled for title and tags in GamesGrid.tsx for when they overflow the element

Halvor Thallaug Fagerli added 6 commits November 9, 2026 16:23
Game now displays in correct size even though there is only (max - n) to display

#25
New fix made the previous change useless, so I changed it back

#25
Rather than just showing a dynamic amount varying on screen size, we now display a fixed amount of 20 games per page. This also suits feedback from user who wanted more games per page. Also a good solution for mobile to save jumping from page to page

#25
In cases of text overflow in titles and tags, the text will now truncate

#73
Changed the score number from "out of 10" to "out of 5" with `score/2` as the showing score. This is to be consistent with the amount of stars. This will hopefully fix the problem with score showing as a date as well

#69
@halvortf halvortf added the enhancement New feature or request label Nov 10, 2026
@halvortf halvortf requested a review from a team as a code owner November 10, 2026 18:48
Copy link
Member

@joelte joelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these look good to me and everything works.
The pagesize change looks good

@halvortf halvortf merged commit e003ddf into dev Nov 11, 2026
@halvortf halvortf deleted the halvor_bugfixes branch November 11, 2026 15:32
Sign in to join this conversation on GitHub.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants